Bug 2034484: Library go bump by eggfoobar · Pull Request #107 · openshift/cluster-csi-snapshot-controller-operator

eggfoobar · 2021-12-16T03:39:01Z

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

Changes:

updated to latest library-go
updated method calls with new signatures
removed passing next generation to ApplyValidationWebhookConfiguration
updated to use explicit call to bind log flags to cli commandline

bertinatto · 2021-12-21T13:06:35Z

 	c.updateSyncError(&instanceCopy.Status.OperatorStatus, syncErr)

-	if _, _, err := v1helpers.UpdateStatus(c.client, func(status *operatorv1.OperatorStatus) error {
+	if _, _, err := v1helpers.UpdateStatus(context.TODO(), c.client, func(status *operatorv1.OperatorStatus) error {


Can you plumb through the ctx variable from starter.go: RunOperator()? You could start by changing the signature of the Run() function to Run(ctx context.Context, workers int).

Sounds great, modified the code to use context

updated library-go to latest Signed-off-by: ehila <ehila@redhat.com>

updated method scalls with new signatures removed passing next generation to ApplyValidationWebhookConfiguration updated to use explicit call to bind log flags to cli commandline Signed-off-by: ehila <ehila@redhat.com> upkeep: removed unused code and small clean up Signed-off-by: ehila <ehila@redhat.com> fix: pull in latest library-go pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>

updated the operator Run() method to pass context through to the sync function Signed-off-by: ehila <ehila@redhat.com>

updated to use component-base/cli package to start operator ran go mod tidy/vendor/verify Signed-off-by: ehila <ehila@redhat.com>

updated unit test to regenerate hash when test object is modified ran go mod tidy/vendor/verify Signed-off-by: ehila <ehila@redhat.com>

eggfoobar · 2022-01-06T22:17:38Z

/retest-required

openshift-ci · 2022-01-06T23:33:50Z

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-07T14:19:17Z

@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

Details

In response to this:

Bug 2034484: Library go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eggfoobar · 2022-01-10T15:57:53Z

/assign @bertinatto

bertinatto

/lgtm

bertinatto

/approve

openshift-ci · 2022-01-10T16:10:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-01-10T16:11:14Z

@eggfoobar: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cloud-credential-operator#434 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2034484 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2034484: Library go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2021

openshift-ci Bot requested review from bertinatto and jsafrane December 16, 2021 03:39

eggfoobar commented Dec 16, 2021

View reviewed changes

Comment thread pkg/operator/webhookdeployment/webhook.go

bertinatto reviewed Dec 21, 2021

View reviewed changes

eggfoobar changed the title ~~[WIP] Library go bump~~ Library go bump Jan 6, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2022

feat: bump library-go

c4b6101

updated library-go to latest Signed-off-by: ehila <ehila@redhat.com>

eggfoobar force-pushed the library_go_bump branch from fee7e33 to 490c5c4 Compare January 6, 2022 14:46

eggfoobar added 4 commits January 6, 2022 09:52

feat: updated operator Run() to pass context

b6e86d0

updated the operator Run() method to pass context through to the sync function Signed-off-by: ehila <ehila@redhat.com>

feat: updated main cmd to use cli.Run()

ef36295

updated to use component-base/cli package to start operator ran go mod tidy/vendor/verify Signed-off-by: ehila <ehila@redhat.com>

fix: updated unit test

3a35269

updated unit test to regenerate hash when test object is modified ran go mod tidy/vendor/verify Signed-off-by: ehila <ehila@redhat.com>

eggfoobar force-pushed the library_go_bump branch from 490c5c4 to 3a35269 Compare January 6, 2022 16:30

eggfoobar changed the title ~~Library go bump~~ Bug 2034484: Library go bump Jan 7, 2022

openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 7, 2022

openshift-ci Bot assigned bertinatto Jan 10, 2022

bertinatto reviewed Jan 10, 2022

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2022

bertinatto reviewed Jan 10, 2022

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022

openshift-merge-robot merged commit f89336c into openshift:master Jan 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2034484: Library go bump#107

Bug 2034484: Library go bump#107
openshift-merge-robot merged 5 commits intoopenshift:masterfrom
eggfoobar:library_go_bump

eggfoobar commented Dec 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bertinatto Dec 21, 2021

Uh oh!

eggfoobar Jan 6, 2022

Uh oh!

eggfoobar commented Jan 6, 2022

Uh oh!

openshift-ci Bot commented Jan 6, 2022

Uh oh!

openshift-ci Bot commented Jan 7, 2022

Uh oh!

eggfoobar commented Jan 10, 2022

Uh oh!

bertinatto left a comment

Uh oh!

bertinatto left a comment

Uh oh!

openshift-ci Bot commented Jan 10, 2022

Uh oh!

openshift-ci Bot commented Jan 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

eggfoobar commented Dec 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bertinatto Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

eggfoobar Jan 6, 2022

Choose a reason for hiding this comment

Uh oh!

eggfoobar commented Jan 6, 2022

Uh oh!

openshift-ci Bot commented Jan 6, 2022

Uh oh!

openshift-ci Bot commented Jan 7, 2022

Uh oh!

eggfoobar commented Jan 10, 2022

Uh oh!

bertinatto left a comment

Choose a reason for hiding this comment

Uh oh!

bertinatto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jan 10, 2022

Uh oh!

openshift-ci Bot commented Jan 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants